Skip to content

docs: replace manual for loop in examples #6490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 18, 2025
Merged

docs: replace manual for loop in examples #6490

merged 2 commits into from
May 18, 2025

Conversation

hrshya
Copy link
Contributor

@hrshya hrshya commented Apr 1, 2025

Resolves none .

Description

What is the purpose of this pull request?

This pull request:

  • replaces manual for loop in examples for math/base/special/polygamma, math/base/special/pow, math/base/special/powm1, math/base/special/rad2deg, math/base/special/rad2degf and math/base/special/rcbrt packages.

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves no related issues.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added Math Issue or pull request specific to math functionality. Needs Review A pull request which needs code review. labels Apr 1, 2025
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Apr 1, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
math/base/special/polygamma $\color{red}1266/1318$
$\color{green}+96.05\%$ 		$\color{red}128/155$
$\color{green}+82.58\%$ 		$\color{green}16/16$
$\color{green}+100.00\%$ 		$\color{red}1266/1318$
$\color{green}+96.05\%$
math/base/special/pow $\color{red}1380/1382$
$\color{green}+99.86\%$ 		$\color{red}119/120$
$\color{green}+99.17\%$ 		$\color{green}11/11$
$\color{green}+100.00\%$ 		$\color{red}1380/1382$
$\color{green}+99.86\%$
math/base/special/powm1 $\color{green}268/268$
$\color{green}+100.00\%$ 		$\color{green}25/25$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}268/268$
$\color{green}+100.00\%$
math/base/special/rad2deg $\color{green}154/154$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}154/154$
$\color{green}+100.00\%$
math/base/special/rad2degf $\color{green}159/159$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}159/159$
$\color{green}+100.00\%$
math/base/special/rcbrt $\color{green}186/186$
$\color{green}+100.00\%$ 		$\color{green}5/5$
$\color{green}+100.00\%$ 		$\color{green}2/2$
$\color{green}+100.00\%$ 		$\color{green}186/186$
$\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

@kgryte
Copy link
Member

kgryte commented Apr 2, 2025

@hrshya Would you mind resolving the CI failures?

@kgryte
Copy link
Member

kgryte commented Apr 2, 2025

In particular, the examples failures. The test failures stem from tooling limitations, it seems.

@kgryte kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Apr 2, 2025
Planeshifter
Planeshifter approved these changes May 18, 2025
View reviewed changes
Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Will try to get the test CI workflow to not fail properly handle case where lots of downstream packages have to be tested soon...

@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label May 18, 2025
@stdlib-bot stdlib-bot removed the Needs Changes Pull request which needs changes before being merged. label May 18, 2025
@stdlib-bot
Copy link
Contributor

PR Commit Message

docs: replace manual `for` loop in examples

PR-URL: https://github.com/stdlib-js/stdlib/pull/6490

Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Harsh <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit 544385d into stdlib-js:develop May 18, 2025
28 of 29 checks passed
@hrshya hrshya deleted the docs/polygamma branch October 11, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Planeshifter Planeshifter Planeshifter approved these changes

Assignees

No one assigned

Labels

Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hrshya @stdlib-bot @kgryte @Planeshifter